Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows MSVC support for the SHADERC_LIB_DIR option #55

Closed
wants to merge 1 commit into from

Conversation

ejohns32
Copy link

Currently the SHADERC_LIB_DIR only works for windows-gnu (and unix systems), but google/shaderc also provides the prebuilt library for MSVC on their downloads page.

NOTE: this is a prerequisite for fixing Issue #39 (but also useful on it's own)

TESTING: it works on my machine ;)
(I used it transitively through vulkano-shaders in a personal project)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@antiagainst
Copy link
Collaborator

Hey @ejohns32, thanks for the contribution! But in order for me to merge this PR, you'll need to assign CLA. I've merged #60 addresses the same problem. I'll close this one and please report if you still see the issue! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants