Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Client-Side CAB token generation. #1598

Open
wants to merge 2 commits into
base: client-side-cab
Choose a base branch
from
Open

feat: Implement Client-Side CAB token generation. #1598

wants to merge 2 commits into from

Conversation

huangjiahua
Copy link

@huangjiahua huangjiahua commented Dec 12, 2024 •
edited
Loading

Implement Client-Side CAB token generation.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@huangjiahua
feat: Implement Client-Side CAB token generation.
d590d61 
Change-Id: I2c217656584cf5805297f02340cbbabca471f609
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Dec 12, 2024
@huangjiahua huangjiahua changed the title Generate cab feat: Implement Client-Side CAB token generation. Dec 12, 2024
@huangjiahua
Add tests for token generation.
c9af3ff 
Change-Id: Ibe6ab966ca7f944a5b9f10324ec4c9071f742b3f
@huangjiahua huangjiahua marked this pull request as ready for review December 12, 2024 22:10
@huangjiahua huangjiahua requested review from a team as code owners December 12, 2024 22:10
nbayati
nbayati reviewed Jan 2, 2025
View reviewed changes
...java/com/google/auth/credentialaccessboundary/ClientSideCredentialAccessBoundaryFactory.java
String intermediaryToken, sessionKey;
Date intermediaryTokenExpirationTime;

synchronized (this) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a synchronized block here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbayati nbayati nbayati left review comments

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huangjiahua @nbayati