Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(GCS+gRPC): format gRPC metric names #14381

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 27, 2024

Part of the work for #13998


This change is Reviewable

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (52e16d5) to head (bab80b6).

Files Patch % Lines
.../storage/internal/grpc/metrics_exporter_options.cc 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14381      +/-   ##
==========================================
- Coverage   93.06%   93.06%   -0.01%     
==========================================
  Files        2191     2191              
  Lines      193206   193207       +1     
==========================================
- Hits       179810   179806       -4     
- Misses      13396    13401       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review June 27, 2024 12:57
@coryan coryan requested review from a team as code owners June 27, 2024 12:57
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: use the returned MetricFormatterOption in a unit test on some known grpc metric name

Or factor out the function and add unit tests for it?

@coryan
Copy link
Contributor Author

coryan commented Jun 27, 2024

/gcbrun

@coryan coryan enabled auto-merge (squash) June 27, 2024 13:58
@coryan coryan merged commit a991917 into googleapis:main Jun 27, 2024
66 checks passed
@coryan coryan deleted the impl-GCS+gRPC-format-grpc-metric-names branch June 27, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants