refactor(storage): make some code more testable #14429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just changes `storage::internal::RetryObjectReadSource` to make the class more testable. The backoff function is provided as an argument, so it can be mocked. Likewise, the code to start new downloads is provided by a factory function. Incidentally, I captured the current options using `internal::ImmutableOptions`, saving a number of copies in the process.
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14429 +/- ##
==========================================
- Coverage 93.58% 93.58% -0.01%
==========================================
Files 2313 2313
Lines 206884 206894 +10
==========================================
+ Hits 193615 193619 +4
- Misses 13269 13275 +6 ☔ View full report in Codecov by Sentry. |
dbolduc
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just changes
storage::internal::RetryObjectReadSourceto make theclass more testable. The backoff function is provided as an argument, so
it can be mocked. Likewise, the code to start new downloads is provided
by a factory function.
Incidentally, I captured the current options using
internal::ImmutableOptions, saving a number of copies in the process.Part of the work for #14424
This change is