cleanup(storage): move test protos #14508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
coryan
force-pushed
the
cleanup-storage-move-test-protos
branch
from
61376dc to
8a3539f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14508 +/- ##
=======================================
Coverage 93.58% 93.59%
=======================================
Files 2318 2318
Lines 206995 206995
=======================================
+ Hits 193716 193729 +13
+ Misses 13279 13266 -13 ☔ View full report in Codecov by Sentry. |
bajajneha27
approved these changes
Jul 25, 2024
|
Thanks @bajajneha27 . @googleapis/cloud-cxx-owners I still need a review from you folks, as this moves files outside |
dbolduc
reviewed
Jul 29, 2024
cmake/GoogleCloudCppFeatures.cmake
Outdated
Comment on lines
404
to
406
| elseif ("${feature}" STREQUAL "storage") | ||
| add_subdirectory(protos/google/cloud/storage/tests) | ||
| add_subdirectory(google/cloud/storage) |
There was a problem hiding this comment.
I think this stops building google/cloud/storage/examples
There was a problem hiding this comment.
Right you are. Fixed.
coryan
force-pushed
the
cleanup-storage-move-test-protos
branch
from
8a3539f to
9fe6b04
Compare
dbolduc
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #14507
This change is