cleanup(generator): fewer query params already in body

[dbolduc]

Part of the work for #14492

When body = "*", we include the whole request as the payload. This means we do not need to include any individual fields in the request as query parameters.

Spec:
https://github.com/googleapis/googleapis/blob/a91d1a37cb86a0e49fdc21d8b4416eb1c2a083ec/google/api/http.proto#L169-L173

---

I removed a failing unit test which was setting a different expectation.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (424ca3c) to head (8e1a747).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14560   +/-   ##
=======================================
  Coverage   93.58%   93.59%           
=======================================
  Files        2318     2318           
  Lines      206995   206974   -21     
=======================================
- Hits       193723   193708   -15     
+ Misses      13272    13266    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[scotthart]

Reviewable status: 0 of 29 files reviewed, 1 unresolved discussion (waiting on @dbolduc)

---

generator/internal/http_option_utils_test.cc line 608 at r1 (raw file):

}

TEST_F(HttpOptionUtilsTest, SetHttpGetQueryParametersGetPaginated) {

Instead of removing this test, let's change the rpc definition in the service.proto to have bindings that mimic an paginated rpc.

[dbolduc]

Instead of removing this test, let's change the rpc definition in the service.proto to have bindings that mimic an paginated rpc.

I don't totally agree, but I think I found a compromise.

I think the important thing is that we verify that the emitted generator code sets the right query parameters. There are golden unit tests for that, e.g. this one which is paginated:

google-cloud-cpp/generator/integration_tests/tests/golden_kitchen_sink_rest_stub_test.cc

Lines 173 to 174 in b48048f

	EXPECT_THAT(request.GetQueryParameter("page_token"),
	Contains("my_page_token"));

---

To support repeated fields, we are going to have to refactor the generator output. We will need to go from:

rest_internal::Get<>(..., {std::make_pair("foo", request.foo()});

to

// This code is not exact, but it demonstrates the point.
std::vector<std::pair<std::string, std::string>>> query_params;
query_params.push_back(std::make_pair("foo", request.foo()));
for (auto bar : request.bars()) {
  query_params.push_back(std::make_pair("bar", bar));
}

rest_internal::Get<>(..., std::move(query_params));

So I think verifying that the http_method_query_parameters variable utters the names of the fields (e.g. foo, bar) we want to set is a good checkpoint that should be refactor-proof.

[scotthart]

Reviewed 1 of 2 files at r1, 26 of 26 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dbolduc)