Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix emulator command arg data-dir #1695

Merged
merged 3 commits into from
Jan 4, 2025
Merged

fix: Fix emulator command arg data-dir #1695

merged 3 commits into from
Jan 4, 2025

Conversation

cindy-peng
Copy link
Contributor

The current gcloudRunner doesn't take any --data-dir flag due to a bug. This PR is to fix the --data-dir flag.

@cindy-peng cindy-peng requested review from a team as code owners January 2, 2025 20:29
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/java-datastore API. labels Jan 2, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jan 2, 2025
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/AllocateIdsResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ArrayValue.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ArrayValueOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/BeginTransactionResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CommitResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CompositeFilter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/CompositeFilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/DatastoreProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Entity.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityResult.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/EntityResultOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Filter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/FilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQuery.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryParameter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/GqlQueryParameterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Key.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KeyOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KindExpression.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/KindExpressionOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/LookupResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Mutation.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationResult.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/MutationResultOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PartitionId.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PartitionIdOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Projection.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ProjectionOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyFilter.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyFilterOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyOrder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyOrderOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyReference.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/PropertyReferenceOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Query.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryProto.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryResultBatch.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/QueryResultBatchOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReadOptions.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReadOptionsOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ReserveIdsResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RollbackResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryRequest.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryRequestOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryResponse.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/RunQueryResponseOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/TransactionOptions.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/TransactionOptionsOrBuilder.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/Value.java
  • proto-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/ValueOrBuilder.java

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Jan 4, 2025
@cindy-peng cindy-peng added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 4, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9d53195 into main Jan 4, 2025
22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 4, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the cindy/fixemulator branch January 4, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cindy-peng @daniel-sanche @yoshi-kokoro @cloud-java-bot