feat: update DatabaseMetaData to include named schemas (#1733)

googleapis · Sep 2, 2024 · b162e2a · b162e2a
1 parent 5dbf223
commit b162e2a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java b/src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java
@@ -419,27 +419,27 @@ public String getCatalogSeparator() {
 
   @Override
   public boolean supportsSchemasInDataManipulation() {
-    return false;
+    return true;
   }
 
   @Override
   public boolean supportsSchemasInProcedureCalls() {
-    return false;
+    return true;
   }
 
   @Override
   public boolean supportsSchemasInTableDefinitions() {
-    return false;
+    return true;
   }
 
   @Override
   public boolean supportsSchemasInIndexDefinitions() {
-    return false;
+    return true;
   }
 
   @Override
   public boolean supportsSchemasInPrivilegeDefinitions() {
-    return false;
+    return true;
   }
 
   @Override
@@ -602,7 +602,7 @@ public int getMaxIndexLength() {
 
   @Override
   public int getMaxSchemaNameLength() {
-    return 0;
+    return 128;
   }
 
   @Override

diff --git a/src/test/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaDataTest.java b/src/test/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaDataTest.java
@@ -112,7 +112,7 @@ public void testTrivialMethods() throws SQLException {
     assertEquals(8000, meta.getMaxIndexLength());
     assertEquals(0, meta.getMaxProcedureNameLength());
     assertEquals(0, meta.getMaxRowSize());
-    assertEquals(0, meta.getMaxSchemaNameLength());
+    assertEquals(128, meta.getMaxSchemaNameLength());
     assertEquals(1000000, meta.getMaxStatementLength());
     assertEquals(0, meta.getMaxStatements());
     assertEquals(128, meta.getMaxTableNameLength());
@@ -245,11 +245,11 @@ public void testTrivialMethods() throws SQLException {
     assertTrue(meta.supportsResultSetHoldability(ResultSet.CLOSE_CURSORS_AT_COMMIT));
     assertFalse(meta.supportsResultSetHoldability(ResultSet.HOLD_CURSORS_OVER_COMMIT));
     assertFalse(meta.supportsSavepoints());
-    assertFalse(meta.supportsSchemasInDataManipulation());
-    assertFalse(meta.supportsSchemasInIndexDefinitions());
-    assertFalse(meta.supportsSchemasInPrivilegeDefinitions());
-    assertFalse(meta.supportsSchemasInProcedureCalls());
-    assertFalse(meta.supportsSchemasInTableDefinitions());
+    assertTrue(meta.supportsSchemasInDataManipulation());
+    assertTrue(meta.supportsSchemasInIndexDefinitions());
+    assertTrue(meta.supportsSchemasInPrivilegeDefinitions());
+    assertTrue(meta.supportsSchemasInProcedureCalls());
+    assertTrue(meta.supportsSchemasInTableDefinitions());
     assertFalse(meta.supportsSelectForUpdate());
     assertFalse(meta.supportsStatementPooling());
     assertFalse(meta.supportsStoredFunctionsUsingCallSyntax());