Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support float32 in mock server #2937

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Mar 3, 2024

Adds support for float32 to the mock server for testing. Also adds a couple of tests that can be used to verify that the mock server supports all types, and that verifies that the client library reads and encodes all types correctly. These tests can be overridden by frameworks using the Java client (e.g. JDBC and PGAdapter) to verify that these also handle these types correctly when used through the API of that tool (I.e. through JDBC or PostgreSQL wire-protocol).

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 3, 2024
@olavloite olavloite marked this pull request as ready for review March 4, 2024 09:05
@olavloite olavloite requested a review from a team as a code owner March 4, 2024 09:05
@olavloite olavloite requested a review from arpan14 March 4, 2024 09:05
@olavloite olavloite added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 66ddf6c into main Mar 4, 2024
27 of 28 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the support-float32-in-mock-server branch March 4, 2024 09:38
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants