fix: AsyncTransactionManager did not always close the session #3580
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a case where the following happens, the session that was used by an AsyncTransactionManager would not be returned to the pool: 1. The transaction is abandoned without a Commit or Rollback call. 2. The AsyncTransactionManager then executes a RollbackAsync internally. 3. If the internal RollbackAsync failed, then the session would not be closed.
product-auto-label
bot
added
size: s
sakthivelmanii
approved these changes
Jan 3, 2025
rahul2393
approved these changes
Jan 3, 2025
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jan 6, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.83.0` -> `6.84.0` | | [org.assertj:assertj-core](https://assertj.github.io/doc/#assertj-core) ([source](https://github.com/assertj/assertj)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.27.1` -> `3.27.2` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.44` -> `2.29.45` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.44` -> `2.29.45` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.44` -> `2.29.45` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.44` -> `2.29.45` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.44` -> `2.29.45` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.44` -> `2.29.45` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.84.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6840-2025-01-06) ##### Features - Add support for ARRAY\<STRUCT> to CloudCilentExecutor ([#​3544](googleapis/java-spanner#3544)) ([6cbaf7e](googleapis/java-spanner@6cbaf7e)) - Add transaction runner for connections ([#​3559](googleapis/java-spanner#3559)) ([5a1be3d](googleapis/java-spanner@5a1be3d)) - Exposing InstanceType in Instance configuration (to define PROVISIONED or FREE spanner instance) ([8d295c4](googleapis/java-spanner@8d295c4)) - Improve tracing by adding attributes ([#​3576](googleapis/java-spanner#3576)) ([eee333b](googleapis/java-spanner@eee333b)) - **spanner:** Add jdbc support for external hosts ([#​3536](googleapis/java-spanner#3536)) ([801346a](googleapis/java-spanner@801346a)) ##### Bug Fixes - AsyncTransactionManager did not always close the session ([#​3580](googleapis/java-spanner#3580)) ([d9813a0](googleapis/java-spanner@d9813a0)) - Retry specific internal errors ([#​3565](googleapis/java-spanner#3565)) ([b9ce1a6](googleapis/java-spanner@b9ce1a6)) - Update max_in_use_session at 10 mins interval ([#​3570](googleapis/java-spanner#3570)) ([cc1753d](googleapis/java-spanner@cc1753d)) ##### Dependencies - Update opentelemetry.version to v1.45.0 ([#​3531](googleapis/java-spanner#3531)) ([78c82ed](googleapis/java-spanner@78c82ed)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 89058b2cef6e62653b7c19ce971a25a1dff13e6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a case where the following happens, the session that was used by an AsyncTransactionManager would not be returned to the pool: