Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support benchmark on older versions of bigframes #1050

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

chore: support benchmark on older versions of bigframes #1050

wants to merge 5 commits into from

Conversation

Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Oct 4, 2024 •
edited
Loading

And add an error column for error traceback.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 4, 2024
@Genesis929 Genesis929 changed the title Benchmark traceback huanc chore: support benchmark on older versions of bigframes Oct 4, 2024
@Genesis929 Genesis929 marked this pull request as ready for review October 4, 2024 19:30
@Genesis929 Genesis929 requested review from a team as code owners October 4, 2024 19:30
@Genesis929 Genesis929 requested a review from sycai October 4, 2024 19:30
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 4, 2024
@Genesis929 Genesis929 marked this pull request as draft October 7, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai sycai approved these changes

Assignees

@ivansmf ivansmf

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Genesis929 @sycai @ivansmf