Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for LinearRegression.predict_explain and LogisticRegression.predict_explain parameter, top_k_features #1228

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: add support for LinearRegression.predict_explain and LogisticRegression.predict_explain parameter, top_k_features #1228

wants to merge 17 commits into from
+100 −24

Conversation

arwas11
Copy link
Contributor

@arwas11 arwas11 commented Dec 17, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • LinearRegression.predict_explain: screen/9r8LBsRSSsyfTxF
    • LogisticRegression.predict_explain: screen/At4T5V5uAsTnuUx

Fixes #379743762 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 17, 2024
@arwas11 arwas11 marked this pull request as ready for review December 17, 2024 20:33
@arwas11 arwas11 requested review from a team as code owners December 17, 2024 20:33
@arwas11 arwas11 requested a review from jialuoo December 17, 2024 20:33
@arwas11 arwas11 requested a review from tswast December 17, 2024 20:34
arwas11 and others added 10 commits December 17, 2024 14:52
@arwas11
update test
c722f10
@arwas11
Merge remote-tracking branch 'origin/b379743612-support-predict-expla…
7d78018 
…in-params' into b379743612-support-predict-explain-params
@arwas11
Merge remote-tracking branch 'origin/b379743612-ml-logistic-regressio…
430ff9f 
…n-explain-predict' into b379743612-support-predict-explain-params
@arwas11
update logistic reg method with the new param
70108f9
@arwas11
add and test new param's validation
26f16b3
@arwas11
resolve merge conflict
ca7b2d3
@arwas11
Merge branch 'main' into b379743612-support-predict-explain-params
576dbb0
@arwas11
Merge remote-tracking branch 'origin/main' into b379743612-support-pr…
fe7ebbe 
…edict-explain-params
@arwas11
Merge remote-tracking branch 'origin/b379743612-support-predict-expla…
1311162 
…in-params' into b379743612-support-predict-explain-params
@arwas11
Merge branch 'main' into b379743612-support-predict-explain-params
0971bf6
tswast
tswast approved these changes Dec 20, 2024
View reviewed changes
bigframes/ml/linear_model.py Outdated Show resolved Hide resolved
@tswast tswast enabled auto-merge (squash) December 20, 2024 17:41
@tswast tswast changed the title chore: add support for predict_explain parameter, top_k_features feat: add support for LinearRegression.predict_explain and LogisticRegression.predict_explain parameter, top_k_features Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@jialuoo jialuoo Awaiting requested review from jialuoo jialuoo is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@shobsi shobsi

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arwas11 @tswast @shobsi