ENH: Add credentials argument to read_gbq and to_gbq. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates private_key parameter.
|
Travis build: https://travis-ci.org/tswast/pandas-gbq/builds/446894492 |
max-sixty
approved these changes
Oct 26, 2018
docs/source/howto/authentication.rst
Outdated
| credentials = google.oauth2.service_account.Credentials.from_service_account_file( | ||
| 'path/to/key.json', | ||
| ) | ||
| df = pandas_gbq.read_gbq(sql, project_id="YOUR-PROJECT-ID", credentials=credentials) |
There was a problem hiding this comment.
Should we swap the order of these? I don't use service accounts outside of GCP much; is it right that people use files far more often than the writing the full definition?
There was a problem hiding this comment.
You're right. Files are more common. Swapped.
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates private_key parameter.
Note: I didn't actually add a deprecation warning message yet because I don't know which version of pandas this change will get added to.
Towards #161