Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add generation of pb2 files via owlbot/bazel #124

Draft
wants to merge 1 commit into
base: remove-proto-files
Choose a base branch
from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 27, 2024

This PR is built on top of #122 and #123. This PR requires changes to build rules in googleapis/googleapis. I'll mark this PR as ready for review once the changes to the build rules are live.

I tested the changes locally using the commands below and the results are in #125.

In a clone of googleapis/googleapis, run

gbazelisk build //google/iam/v1/logging:audit-data-py
gbazelisk build //google/iam/v1:iam-v1-py

The in a clone of this repo, run

docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v <path to your bazel-bin>:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --source-dir /bazel-bin --dest /repo

and

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

@parthea parthea requested a review from a team as a code owner December 27, 2024 20:42
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: iam Issues related to the googleapis/python-grpc-google-iam-v1 API. labels Dec 27, 2024
@parthea parthea marked this pull request as draft December 27, 2024 20:44
@parthea
Copy link
Contributor Author

parthea commented Dec 27, 2024

Wait for cl/710118578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: iam Issues related to the googleapis/python-grpc-google-iam-v1 API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants