Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add generation of pb2 files via owlbot/bazel #328

Draft
wants to merge 1 commit into
base: remove-proto-files
Choose a base branch
from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 27, 2024

This PR is built on top of #326 and #327. This PR requires changes to build rules in googleapis/googleapis. I'll mark this PR as ready for review once the changes to the build rules are live.

I tested the changes locally using the commands below and the results are in #329

In a clone of googleapis/googleapis, run

gbazelisk build //google/cloud/orgpolicy/v1:orgpolicy-v1-py
gbazelisk build //google/cloud/orgpolicy/v2:orgpolicy-v2-py

The in a clone of this repo, run

docker run --rm --user $(id -u):$(id -g)   -v $(pwd):/repo   -v <path to your bazel-bin>:/bazel-bin   gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-bazel-bin   --source-dir /bazel-bin --dest /repo

and

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

Fixes googleapis/python-api-common-protos#22

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: orgpolicy Issues related to the googleapis/python-org-policy API. labels Dec 27, 2024
@parthea parthea changed the base branch from main to remove-proto-files December 27, 2024 19:40
@parthea parthea mentioned this pull request Dec 27, 2024
@parthea
Copy link
Contributor Author

parthea commented Dec 27, 2024

Wait for cl/710105979

@parthea parthea changed the title Add generation via bazel owlbot chore: add generation of pb2 files via owlbot/bazel Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: orgpolicy Issues related to the googleapis/python-org-policy API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant