-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Maps SDK for iOS in .xcframework to ease SPM integration #329
Comments
As the confused in #326 I'm a proponent. Without it being included I have to maintain Google Maps manually or use Carthage, both of which require a lot of extra steps I'd rather not mess with again. Cocoapods is not an option for my team. Additionally I think it'd be a great idea for google-maps-ios-utils to maintain the proper Google Maps version. If there is an version incompatibility down the road, it'd be on the developer to figure out the issue and update either this or Google Maps to the appropriate version. |
@michael-mckenna curious... why is CocoaPods not an option for your team? |
Mainly two reasons. The primary is that we are transitioning to SwiftPM as it's the officially supported dependency manager. The second is that cocoapods lead to dreadfully slow incremental build times which slowed the development cycle. Switching to Carthage remediated that issue, so there's no looking back for us ;) if memory serves me correctly, we got our incremental build times down from 1m45s on cocoapods to 23s with Carthage. This was also 2-3 years ago. |
Wow, that's quite a huge difference 😅 Thanks for providing context. |
@arriolac Will this integration allow building for macOS catalyst? somewhat relevant. Right now, I can't build for catalyst form the frameworks in the google maps zip |
@michael-mckenna the built XCFramework simply mirrors the architectures that are currently supported by the SDK (arm64 |
+1 for a solution that would allow using only the officially supported dependency manager. |
Don't forget add arm64 for Simulators, so we can use it on new arm macs 😉 |
This is marked as good first issue, but it’s really up to the maintainers and distributors of https://cocoapods.org/pods/GoogleMaps. There is a lot of good information on xcframeworks here: https://github.com/bielikb/xcframeworks. It’s likely a simplification of the existing process for packaging the GoogleMaps framework and wouldn’t take much effort for someone to repackage it. It is probably possible that someone external to google could download the existing release and repackage it as an xcframework, but I doubt Google wants the officially supported way to use google maps for spm and m1 macs to be: download a modified version of our binaries from someone else... |
I filed this issue considering that the existing Maps SDK for iOS .framework could be packaged into the Maps SDK for iOS Utility library .xcframework. However, that's not really how SPM packages work. Rather, the steps to mark this issue fixed would be: (1) for the Maps SDK for iOS to support .xcframeworks, and (2) update Package.swift for this repo and specify Maps SDK for iOS as a dependency. (1) needs to be done by us, and (2) can be done by us or a contributor. Since this issue is blocked by (1), I'll remove the (1) currently has no ETA so if you are using .xcframework version of this library you will need to include the Maps SDK for iOS dependency in addition using one of the installation options (CocoaPods, Carthage, or manual). |
Big +1 to this issue. I'd love to see GoogleMaps properly available via SPM. It's the primary blocker in moving my large app fully onto SPM now. |
Any update on this issue? It’s a blocker for a lot of users. |
Please see my comment here googlemaps-samples/maps-sdk-for-ios-samples#70 (comment) |
Any update on this feature request? |
+1, still waiting |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
+1 After the release of the SPM-compatible GoogleSignIn SDK this week, the Google Maps SDK is the last one for us that does not yet support SPM. So this would be highly appreciated🤞 |
+1 |
2 similar comments
+1 |
+1 |
+1 |
3 similar comments
+1 |
+1 |
+1 |
Any update on when SPM will be available for google maps. |
This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you! |
+1 still waiting for this update. |
+1 |
6 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you! |
Any update on when SPM will be available for google maps |
+1 |
+10 |
Hi folks, I see the need here. I recommend "starring" the issue on the Maps SDK for iOS Public Issue Tracker as the best way to get notified when SPM support is available for the Maps SDK for iOS. That's the first priority, then the subsequent packaging in this Utils library will be easier. |
Comment or +1 this issue if this is something you'd like to see in the library so it can be prioritized. Also a good candidate for contributions.
Is your feature request related to a problem? Please describe.
Currently, integrating this library with SPM requires that developers additionally include Maps SDK for iOS either via CocoaPods or Carthage. In other words, the Maps SDK is not packaged in the
.xcframework
which causes additional friction and confusion (see #326) while using this library.Describe the solution you'd like
The Maps SDK for iOS should be included in the
.xcframework.zip
asset on each release so that developers can just include the iOS Utils library.Describe alternatives you've considered
Keep existing integration.
Additional context
See #326
The text was updated successfully, but these errors were encountered: