This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
Support new Bulletproof rewind scheme #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable first 8 byte check Extend message by 4 bytes Change message to 20 bytes, fix warnings Update tests Update benchmark Allow private nonce for regular bulletproof creation
garyyu
added a commit
that referenced
this pull request
Feb 13, 2020
* Merged in commit (pull request #1) signature with pedersen commitment as key * signature with pedersen commitment as key * refactoring for compliance to ComSig signature spec * fix the build * tmp add 2 printf for debug test * fix the test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a squashed version of mimblewimble#48
It does a few things:
gamma*G + v*H == commit, this will be replaced by a re-derivation of the commitment using the recovered amount and message at the wallet levelThere are accompanying changes in rust-libsecp and grin that need to be merged at the same time to not break backwards compatibility.