Experimental Websockets merge #4131
Open
+2,679
−671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle dialing errors
Basic Autobahn test suite
Fixes from autobahn
Various fixes for races and leaking goroutines
Trying more to not deadlock
This commit also includes updates of transilient dependencies, which fix swcurity-related concerns.
* feat: allow name tag, and overwrite url tag with name tag if set * fix: remove unnecessary assignment on name tag. use same value for both url and name tags.
* Add support for Blob * Make 'Blob instanceof Blob' be true * Split subtests into separated tests * Error out on non-defined binaryType * Unexport 'blob' Go struct * Fix linter complaints * Use 'must' helper to set obj props * Add support for Blob.stream() * Add some tests for Blob's public methods * Update README.md with Blob support * Tidy up Go module * Fix linter complaints * Downgrade modules upgraded by mistake * Remove toolchain directive from go.mod * Undo deps update * Apply suggestions from code review * Extend the support for Blob * Support .send() for Blob * Support Blob() for Blob and DataView * Stop relying on '_ref' internal attribute * Fix linter complaints * Fix TestBlob/ArrayBuffer * Make 'isBlob' work independently of 'rt.GlobalObject()'
for some reason - likely a bug in goja/Sobek returning a type that is uint8 under the hood (or int) doesn't actually get to be a number in js. The current fix casts the ReadyState type to uint8 so that Sobek handles it correctly. Fixes #79
mstoykov
requested review from
inancgumus and
ankur22
and removed request for
a team
mstoykov
force-pushed
the
websocketsMerge
branch
from
93bcaeb to
36f8fb3
Compare
mstoykov
force-pushed
the
websocketsMerge
branch
from
36f8fb3 to
4cf561d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move k6/experimental/websockets code under k6.
Why?
As part of the removing from experiimental this is required.
Note that this change does not change anything else just brings the code in
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)