Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Cloud Deployment Azure #15397

Merged
merged 12 commits into from
Jan 8, 2025
Merged

docs: Cloud Deployment Azure #15397

merged 12 commits into from
Jan 8, 2025

Conversation

Jayclifford345
Copy link
Contributor

What this PR does / why we need it:
Continuation of the cloud deployment guides. This teaches the user how to deploy Loki on Azure using the helm. Including:

  • Azure Setup
  • Helm values config
  • Testing
    I have also added some opinionated recommendations to the helm index page for review aswell.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner December 12, 2024 17:13
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 12, 2024
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] One thing I noticed, there's a lot of bolding in this PR. Try to use bold sparingly, because if you use it too much, it starts to lose its emphasis.

docs/sources/setup/install/helm/_index.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
@Jayclifford345
Copy link
Contributor Author

Hey @JStickler that is the changes in and ready for your review :)

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] Looking good!

docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
docs/sources/setup/install/helm/deployment-guides/azure.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 20, 2024

💻 Deploy preview deleted.

@Jayclifford345
Copy link
Contributor Author

Happy new year @JStickler! Ready for another review

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] A couple more suggestions, but LGTM.

@DylanGuedes DylanGuedes merged commit 672f91c into main Jan 8, 2025
62 checks passed
@DylanGuedes DylanGuedes deleted the cloud-deployment-azure branch January 8, 2025 13:18
@Jayclifford345
Copy link
Contributor Author

Thanks @DylanGuedes! @JStickler I think we will need a backport on this :)

loki-gh-app bot pushed a commit that referenced this pull request Jan 8, 2025
**What this PR does / why we need it**:
Continuation of the cloud deployment guides. This teaches the user how to deploy Loki on Azure using the helm. Including:
* Azure Setup
* Helm values config
* Testing

(cherry picked from commit 672f91c)
loki-gh-app bot pushed a commit that referenced this pull request Jan 8, 2025
**What this PR does / why we need it**:
Continuation of the cloud deployment guides. This teaches the user how to deploy Loki on Azure using the helm. Including:
* Azure Setup
* Helm values config
* Testing

(cherry picked from commit 672f91c)
loki-gh-app bot pushed a commit that referenced this pull request Jan 8, 2025
**What this PR does / why we need it**:
Continuation of the cloud deployment guides. This teaches the user how to deploy Loki on Azure using the helm. Including:
* Azure Setup
* Helm values config
* Testing

(cherry picked from commit 672f91c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants