Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove duplicated title #15530

Merged
merged 6 commits into from
Jan 7, 2025
Merged

docs: remove duplicated title #15530

merged 6 commits into from
Jan 7, 2025

Conversation

lvqq
Copy link
Contributor

@lvqq lvqq commented Dec 21, 2024

What this PR does / why we need it:
Two duplicated title is weired, so just keep one:
https://grafana.com/docs/loki/latest/get-started/quick-start/#complete-metrics-logs-traces-and-profiling-example
image

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@lvqq lvqq requested a review from a team as a code owner December 21, 2024 02:06
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 21, 2024
@JStickler
Copy link
Contributor

@lvqq Thanks for updating your PR. You need to sign the CLA before I can merge this.

@lvqq
Copy link
Contributor Author

lvqq commented Jan 7, 2025

@JStickler Done

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

@JStickler JStickler merged commit 50d8d9c into grafana:main Jan 7, 2025
60 of 61 checks passed
loki-gh-app bot pushed a commit that referenced this pull request Jan 7, 2025
Signed-off-by: chlorine <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 50d8d9c)
loki-gh-app bot pushed a commit that referenced this pull request Jan 7, 2025
Signed-off-by: chlorine <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 50d8d9c)
loki-gh-app bot pushed a commit that referenced this pull request Jan 7, 2025
Signed-off-by: chlorine <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 50d8d9c)
loki-gh-app bot pushed a commit that referenced this pull request Jan 7, 2025
Signed-off-by: chlorine <[email protected]>
Co-authored-by: J Stickler <[email protected]>
(cherry picked from commit 50d8d9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3.0.x backport release-3.1.x backport release-3.2.x backport release-3.3.x size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants