Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(block-scheduler): introduce job lease and requeue expired jobs #15560

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Dec 30, 2024

What this PR does / why we need it:

Introduces a job lease checker to expire jobs that have not received any updates from the builders for -jobqueue.lease-duration. Expired jobs are immediately re-enqueued so that this work can be assigned to another available builder.
This is helpful when a builder that picked a job is now unavailable either because it restarted, crashed or has become unresponsive, in such cases it is better to assign this work to another builder so as to not fall behind.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Dec 30, 2024
@ashwanthgoli ashwanthgoli marked this pull request as ready for review December 30, 2024 13:35
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner December 30, 2024 13:35
Copy link
Contributor

github-actions bot commented Dec 30, 2024

💻 Deploy preview deleted.

@owen-d owen-d merged commit 558080c into main Dec 30, 2024
61 checks passed
@owen-d owen-d deleted the blockscheduler-lease branch December 30, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants