-
-
Notifications
You must be signed in to change notification settings - Fork 951
Grails Engineering Meeting Notes (11 12 2020)
Jason Schindler edited this page Nov 19, 2020
·
3 revisions
Date: 11/12/2020
- Puneet Behl
- Álvaro Sánchez-Mariscal
- Jason Schindler
- Current Grails Development Activities
- Transfer of Spring Security REST Plugin
- Holiday Schedule for Grails Engineering Meetings
- Open Discussion
- Primarily been fixing bugs and issues in Grails Core
- Looking into updating Spring and Micronaut versions and having some issues because of transitive dependencies in micronaut-spring
- It looks like excluding the dependencies manually resolves this
- The dependency is an older release from Micronaut AOP
- Alvaro: We should bring this up at the next Micronaut engineering meeting to see if these dependencies should be transitive or not
- Also looking at Grails does not auto-create Spring Cloud beans
- Working on: Exception cause threads to hang and drain 100% CPU
- One solution would be only using the regex if
_gsp_file
is actually in the string - *Alvaro: You can try to ask Graeme about this
- I will try to time-box working on this as I don't see where it is actually used
- One solution would be only using the regex if
- Next week will bre reviewing GraphQL PR from James Hardwick
- Alvaro: Spring Security REST Plugin has had a few issues in the last few months and deserves more attention than I can give it
- Alvaro: Right now, ff I was building a Grails 4 app, I would go straight for the spring-security module from Spring
- Alvaro: I propose transferring the repo to the Grails org in GitHub and the Grails team can take care of it as they would any other plugin
- Puneet: I think transferring the plugin to grails-plugins is the right first step
- Puneet: Let me know if there are specific things that need attention let me know and I'll take a look
- Puneet: Also let me know if there is anyone from the community that has worked on it in the past that might be interested in maintaining it
- Alvaro: 80-90% of the maintenance is dependabot updates but in a security plugin it really needs to be done
-
Alvaro: There is one issue that needs to be investigated. If you call
getPrincipal
during bootstrap, all calls will be authenticated
- Jason: I propose that we cancel the meeting the last two weeks of the year as many people will be out for vacation
- Jason: We may also want to consider cancelling the last week of November as it is a holiday in the US (Thanksgiving)
- Puneet: I think we can cancel the December meetings and just add a note that if anyone wants to talk about something we can chat in Slack or set up a call
- Puneet: Let's wait on cancelling the November meeting to see if there is interest in still having it
- Jason: Sure thing. I will not be attending a meeting on November 26th, so someone else will need to take minutes