Add many-to-many fields on polymorphic interface types #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2024 12:44
Most of this is just refactoring to prevent duplication and remove some inlining for clarity.
jvandermey
commented
Dec 19, 2024
Comment on lines
+63
to
+84
| -- TODO: At the moment, relationships do not include polymorphic interfaces. | ||
| -- As a result, the following annotations do not produce many-to-many relationships | ||
| -- on the Person interface. | ||
| COMMENT ON TYPE j.team_membership IS $$ | ||
| @interface mode:union | ||
| @name TeamMembership | ||
| @behavior node | ||
| @ref member to:Person singular | ||
| @ref team to:Team singular | ||
| $$; | ||
|
|
||
| COMMENT ON TABLE j.internal_team_membership IS $$ | ||
| @implements TeamMembership | ||
| @ref member via:(person_id)->j.internal_employee(id) singular | ||
| @ref team via:(team_id)->j.team(id) singular | ||
| $$; | ||
|
|
||
| COMMENT ON TABLE j.external_team_membership IS $$ | ||
| @implements TeamMembership | ||
| @ref member via:(person_id)->j.external_person(id) singular | ||
| @ref team via:(team_id)->j.team(id) singular | ||
| $$; |
There was a problem hiding this comment.
@benjie , something like this is how I was envisioning that this would work for union interface types. Does this approach make sense to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is just refactoring to prevent duplication when extending the fields . It also removes some inlining for clarity.
This will add GQL fields (this will be additive, so should not be breaking) for any schemas that include junction tables with polymorphic tables.
The final commit includes a test for polymorphic junctions to polymorphic union interfaces. The plugin doesn't currently support adding these relationship fields on the interface, but this is something that I hope to add in the future.