Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing to conda #369

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/publish-conda.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Publish Python 🐍 distributions 📦 to Conda

on:
push:
tags:
- '*'
workflow_dispatch:


jobs:
build-n-publish:
name: Build and publish Python 🐍 distributions 📦 to Conda
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: publish-to-conda
uses: blanderbuss/[email protected]
with:
subDir: 'conda'
AnacondaToken: ${{ secrets.ANACONDA_TOKEN }}
platforms: 'linux'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a prepublish test we can do? Ex: In pip, we do a test publish to test.pypi.org first

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After researching, I don't belive that there is a way to perform a test publish for conda

2 changes: 2 additions & 0 deletions bld.bat
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
"%PYTHON%" setup.py install
if errorlevel 1 exit 1
1 change: 1 addition & 0 deletions build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
python setup.py install
65 changes: 65 additions & 0 deletions conda/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
package:
name: graphistry-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing as part of landing, change to graphistry ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

version: "0.25.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version seems hard-coded here, while it should be taken from the git tag -- am I misreading somehow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on it, for some reason this env variable is not present

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by switching to different github action


source:
path: ./

requirements:
host:
- python
- setuptools
run:
- graphistry_dev.graphistry_core
- graphistry_dev.graphistry-umap
- graphistry_dev.graphistry-ai

test:
requires:
- flake8
- mock
- mypy
- pytest
- pandas-stubs
- types-requests

outputs:
- name: graphistry_dev.graphistry_core
requirements:
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anything like outputs.*.description where they can point to the main conda package for instructions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can put instructions in the main description and it will be used for all outputs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check here to see how the description looks like right now

- packaging>=20.1
- typing-extensions
- numpy
- pandas>=0.17.0
- protobuf>=2.6.0
- pyarrow>=0.15.0
- requests
- name: graphistry_dev.graphistry-umap
requirements:
- umap-learn
- dirty_cat
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See setup.py for min dirty_cat version req + add scikit-learn (with min version)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- name: graphistry_dev.graphistry-ai
requirements:
- scikit-learn
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see setup.py for min version reqs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

- scipy
- umap-learn
- dirty_cat
- dgl
- pytorch
- sentence-transformers


about:
home: https://www.graphistry.com/
license: BSD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSD3 + license file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

summary: Visual Graph Analytics library for Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphistry Visual Graph ...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

description: |
Graphistry is a visual graph analytics library for extracting, transforming,
displaying, and sharing big graphs with end-to-end GPU acceleration
doc_url: https://www.graphistry.com/docs
Copy link
Contributor

@lmeyerov lmeyerov Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dev_url: https://github.com/graphistry/pygraphistry

extra:
author: The Graphistry Team
author_email: [email protected]