-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cucat Featurization base #486
Open
tanmoyio
wants to merge
98
commits into
master
Choose a base branch
from
feat/gpu-featurization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+352
−114
Open
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit
Hold shift + click to select a range
cf07249
cucat feat support
tanmoyio d73a2db
cudf test env var added for test_feature_utils.py
tanmoyio 382e18b
some import fixes
tanmoyio 44200ac
passthru DT encode/umap, add back for timebar
dcolinmorgan 777afd4
lint
dcolinmorgan c1bc6f1
updated cu-cat version for optional install
dcolinmorgan 48e4017
type check without loading cudf, via getmodule
dcolinmorgan 6b0b52b
ok we still need the check_cudf def
dcolinmorgan e4b0c0a
swap lazy import defs
dcolinmorgan 7c0c0c6
working thru comments
dcolinmorgan f344dd8
address few issues
dcolinmorgan b6f6388
swap cudf=None type sig for lazy calls
dcolinmorgan f185a2f
swap cudf=None type sig for lazy calls
dcolinmorgan 410c40d
swap cudf=None type sig for lazy calls
dcolinmorgan b9067c0
type check lint
dcolinmorgan 8f0bc3a
lint isinstance all over
dcolinmorgan b7b8e63
lint isinstance all over
dcolinmorgan e8eb85a
rename lazy cucat to cuda
dcolinmorgan 501ff3b
cudf df constructor change
dcolinmorgan 918ebee
towards single engine=cuda flag
dcolinmorgan ccf6f47
towards single engine=cuda flag
dcolinmorgan 60de1cf
single cuda flag
dcolinmorgan 0b66776
lint
dcolinmorgan 9f086c8
robust logging for cu_cat
dcolinmorgan 78015f1
single cuda flag
dcolinmorgan 616009b
assert after if
dcolinmorgan dc38d3b
super > table
dcolinmorgan 376890e
Update feature_utils.py
dcolinmorgan b9828c5
rollback constant CUDA_CAT
dcolinmorgan 8d13cbe
rollback constant CUDA_CAT
dcolinmorgan 92769bf
else all
dcolinmorgan af0fc8a
else all
dcolinmorgan 4f78b76
else all
dcolinmorgan b8a0db2
feat pytest tweaks
dcolinmorgan 6e11117
feat pytest tweaks
dcolinmorgan b0d36cd
see if last commit induced numba install error
dcolinmorgan 5677bea
feat pytest tweaks
dcolinmorgan 8e15e5e
datetime passthrough for cudf
dcolinmorgan 20200d6
add unadulterated dt back
dcolinmorgan 26cd39c
more flexible multi-dt column add
dcolinmorgan c4c1bd8
start DT test
dcolinmorgan d889581
start DT test
dcolinmorgan 48a7308
Merge branch 'master' into feat/gpu-featurization
dcolinmorgan ba25c89
Merge branch 'feat/gpu-featurization' of https://github.com/graphistr…
dcolinmorgan 8a0ab5c
lint
dcolinmorgan 151ab5b
lint
dcolinmorgan d63d729
cucat may be erroneously involked
dcolinmorgan ada126e
maybe fastencoder issue
dcolinmorgan 21a475d
defaulting to cucat, concrete mixedup perhaps
dcolinmorgan 49976e8
defaulting to cucat, concrete mixedup perhaps
dcolinmorgan f24411e
try basic assert isinstance
dcolinmorgan d303afb
nope
dcolinmorgan b34ee85
nope
dcolinmorgan 2456b70
type checking node attributes causing issues
dcolinmorgan 8fc0b22
type checking node attributes causing issues
dcolinmorgan ee6c523
type checking node attributes causing issues
dcolinmorgan 4808428
defaulting to cucat, concrete mixedup perhaps
dcolinmorgan a22e85e
type checking node attributes causing issues
dcolinmorgan 86fc662
type checking node attributes causing issues
dcolinmorgan 614fff4
type checking node attributes causing issues
dcolinmorgan b88e3ea
type checking node attributes causing issues
dcolinmorgan a72d4b1
type checking node attributes causing issues
dcolinmorgan 4eef71c
type checking node attributes causing issues
dcolinmorgan 0522981
check which column is off
dcolinmorgan 73ba5d1
trying everything
dcolinmorgan 9da0b11
remove print, add print
dcolinmorgan f9e9260
same df every time, remove [cols]
dcolinmorgan 58d1461
revert, remove +target_names_node from targets
dcolinmorgan d5acc1a
revert, remove +target_names_node from targets
dcolinmorgan 614d9f3
nan raising equality issues, filled with 0
dcolinmorgan 31b5f5e
add feat tests back
dcolinmorgan bc4f290
Merge branch 'master' into feat/gpu-featurization
dcolinmorgan 74a2460
Merge branch 'feat/gpu-featurization' of https://github.com/graphistr…
dcolinmorgan 624c721
comment anxiety assert
dcolinmorgan 2fc6be5
single cuda engine flag
dcolinmorgan 178adba
try constant substitution
dcolinmorgan 90bd8b7
add cuda/gpu generic engine flag for full gpu pipeline
dcolinmorgan 5d16a9e
most comments
dcolinmorgan e931456
most comments
dcolinmorgan fc212a8
most comments
dcolinmorgan d4b1fbe
most comments
dcolinmorgan 498a4de
most comments
dcolinmorgan aab2ad9
remove single engine flag, try in next PR
dcolinmorgan f0eb1bf
latest cu-cat version
dcolinmorgan 867874d
edge concat interop
dcolinmorgan 5a69233
Merge branch 'master' into feat/gpu-featurization
dcolinmorgan cdda3e7
better dc default
dcolinmorgan 63398b3
renaming
dcolinmorgan b720bc1
renaming
dcolinmorgan ed824ec
cupyx csr toarray for features_out
dcolinmorgan 1735134
cupyx csr toarray for features_out
dcolinmorgan 824d940
cupyx csr toarray for features_out
dcolinmorgan c7ce92c
add gpu-umap test, allow cucat to test w/o gpu
dcolinmorgan 30a04a4
add gpu-umap test, allow cucat to test w/o gpu
dcolinmorgan 50df365
dirty_cat version with Table&SuperVectorizer
dcolinmorgan a654f9f
dirty_cat version with Table&SuperVectorizer
dcolinmorgan a86be5c
better dimension try
dcolinmorgan 4bd056c
Merge branch 'master' into feat/gpu-featurization
dcolinmorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who calls this on import?
And can this be a a) cached call that b) checks module path vs an import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its only
test_embed_utils#L14
that callscheck_cudf
, swapped out forlazy_cudf_import
fromumap_utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, so that shouldn't be the issue, right?
test/*
shouldn't get imported byimport graphistry
..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, no i wasnt clear,
test_embed_utils
is only OTHER placelazy_cudf_import
was present. It was used inembed_utils
and imported cudf to check df dtype, but I have swapped it out in place of just checking via getmodule e.g.if 'cudf' in str(getmodule(self._nodes)):
, so I believe the problem is solved -- tuna looks much better