Adding workflow #185
Adding workflow #185
Conversation
gagoar
commented
Nov 17, 2020
•
gagoar
commented
- Adding workflow
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 12.x | ||
| - name: Install dependencies |
There was a problem hiding this comment.
https://github.com/bahmutov/npm-install this provides some better cacheing
There was a problem hiding this comment.
There is official cache action:
https://github.com/graphql/graphql-js/blob/cd273ad136d615b3f2f4c830bd8891c7c5590c30/.github/workflows/ci.yml#L18-L24
I think we should minimize the number of 3rd-party dependencies especially since this particular one is not very popular.
.github/workflows/validation.yml
Outdated
| @@ -0,0 +1,24 @@ | |||
| name: Lint and Tests | |||
|
|
|||
| on: push | |||
There was a problem hiding this comment.
It will not work on the pull requests.
Can you please copy relevant parts of https://github.com/graphql/graphql-js/blob/master/.github/workflows/ci.yml
It will simplify review and unify setups between projects.
There was a problem hiding this comment.
I will make the change you are asking. but it is not necessary, It will run every time we push to the branch.
as an example this is the same PR to my fork. you will see is running,
Is not running here, because the given permissions on the repo.
There was a problem hiding this comment.
the issue here. is if I add both, GitHub have some issues and it creates duplicated runs. (https://github.community/t/duplicate-checks-on-push-and-pull-request-simultaneous-event/18012)
There was a problem hiding this comment.
We end up with double runs now in my fork, which is not desired.
