-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow to Typescript #191
base: master
Are you sure you want to change the base?
Flow to Typescript #191
Conversation
@gagoar the build failure shows the issue is with how we're set up to resolve the underlying netlify functions. there was some ways to resolve that, similarly to how binary paths are aliased using a static file that |
yea I didn't look deeply into it, till my doubs about the types and how strict I'm doing things was addressed. I will work on this soon! thanks for looking into it. |
@@ -30,7 +30,7 @@ import VehicleType from './vehicle'; | |||
/** | |||
* The GraphQL type equivalent of the Film resource | |||
*/ | |||
const FilmType = new GraphQLObjectType({ | |||
const FilmType: GraphQLObjectType = new GraphQLObjectType({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason if I remove the type from this assignment. I get:
const FilmType: any
The GraphQL type equivalent of the Film resource
'FilmType' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.ts(7022)```
c408ef8
to
23b57cc
Compare
Description.
I've translated everything inside src/ to typescript
TODO
This PR is stacked out of #190