WebDiscover: allow custom labels for single resource enroll (server, kube, eks, rds)

[kimlisa]

part of #46976

• requires Add webapi v2 endpoints for creating discovery token and enrolling eks with labels #50472

recommend reviewing by commit

This PR adds ability to define custom labels for single resource enroll (support for app will be in another PR)

kube story

server story

eks story

rds story

tests done on my staging cluster:

• server
• kube
• single rds
• single eks

changelog: Adds support for defining labels in the web UI for single resource enroll (server, kubernetes, EKS, and RDS)

[ravicious]

I'll continue the review later today!

[ravicious]

I think the double "Next" button might end up being confusing. 😅

Maybe the button could say "Skip adding labels" if there's no labels set and "Finish adding labels" if there's at least one label?

[kimlisa]

i took this design from the helm chart step, b/c it does the same thing 😅. What do you think about Generate Script instead, b/c for both steps, its what it does 🤔

[ravicious]

"Generate Script" / "Generate Command" would work in the case of the screenshot that you posted. Step 2 talks about generating a command, so it wouldn't be unexpected to have a button that says "Generate Command".

In the case of adding a single server, there's no mention of a command, so I feel a button that says "Generate Command" would be out of place there.

[kimlisa]

got it, i edited the button texts

server (

kube:

[ravicious]

Nice. 👍 I think it'd make sense to use title case for these since that's what we use for other buttons (e.g. "Add Another Label", "Add a Label").

[ravicious]

I can't seem to enter labels until I fill out Teleport Service Namespace and Kubernetes Cluster Name first. Would it be possible to validate this only once I click on the first "Next"?

[ravicious]

Now I can enter labels separately from the rest of the inputs, but when I click on the first "Next", it fails with "generateScript is not a function" in the console.

[kimlisa]

this has been fixed, tested both pnpm start-teleport-e and in my staging cluster

if interested here is the updated vite config: https://github.com/gravitational/teleport/pull/50472/files#diff-3ba1ef1723154b05797a019f68c65252cbdbafd733eff347e99575e0378085a7

[ravicious]

I'm still having some issues when adding a single kube cluster.

[ravicious]

Nice. 👍 I think it'd make sense to use title case for these since that's what we use for other buttons (e.g. "Add Another Label", "Add a Label").

[ravicious]

Did you have a chance to investigate what was causing the UI to blow up when the requests weren't properly proxied by the Vite server? It makes me think that perhaps we don't account for a failing request somewhere.