Skip to content

Commit

Permalink
Fixes web-platform-tests#229: broaden the first Safari stable bad run…
Browse files Browse the repository at this point in the history
…s range

This started failing after
web-platform-tests/wpt#15222
(CommitDate: Tue Feb 5 15:37:42 2019 +0000); fixed after
web-platform-tests/wpt#15659
(CommitDate: Thu Mar 7 15:02:41 2019 +0000).

Note that while the commit landed on Mar 7, the Safari stable run
started on Mar 8 10:10:17 2019 +0000 was still prior to this
commit. The first Safari stable run with the fix was started Mar 10
20:05:26 +0000.
  • Loading branch information
gsnedders committed Sep 25, 2024
1 parent 67c603a commit 228b0b7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions bad-ranges.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ const moment = require('moment');
// inclusive start dates and exclusive end dates.

const STABLE_BAD_RANGES = [
// This was some form of Safari outage, undiagnosed but a clear erroneous
// spike in failure rates.
[moment('2019-02-06'), moment('2019-03-04')],
// This was a safaridriver outage, resolved by
// https://github.com/web-platform-tests/wpt/pull/15659
[moment('2019-02-06'), moment('2019-03-09')],
// This was a safaridriver outage, resolved by
// https://github.com/web-platform-tests/wpt/pull/18585
[moment('2019-06-27'), moment('2019-08-23')],
Expand Down
6 changes: 3 additions & 3 deletions test/bad-ranges.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ describe('bad-ranges.js', () => {
it('should advance date at beginning of bad range', () => {
const date = moment('2019-02-06');
const adjusted = advanceDateToSkipBadDataIfNecessary(date);
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-04');
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-09');
});

it('should advance date in middle of bad range', () => {
const date = moment('2019-02-28');
const adjusted = advanceDateToSkipBadDataIfNecessary(date);
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-04');
assert.equal(adjusted.format('YYYY-MM-DD'), '2019-03-09');
});

it('should NOT advance date at end of bad range', () => {
const date = moment('2019-03-04');
const date = moment('2019-03-09');
const adjusted = advanceDateToSkipBadDataIfNecessary(date);
assert.equal(date, adjusted);
});
Expand Down

0 comments on commit 228b0b7

Please sign in to comment.