Give earlier warning when PGP key is misconfigured #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
added a commit
to rtyley/sample-project-using-gha-scala-library-release-workflow
that referenced
this pull request
Jan 13, 2024
rtyley
force-pushed
the
give-earlier-warning-when-pgp-key-misconfigured
branch
2 times, most recently
from
9dbb56f to
4594a23
Compare
rtyley
force-pushed
the
give-earlier-warning-when-pgp-key-misconfigured
branch
from
4594a23 to
de66d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow should fail sooner when the PGP key is misconfigured (usually because of missing access to a secret).
Related: #17
There should ideally also be an early fatal error if the key is passphrase-protected, we only support passphrase-less PGP keys - https://security.stackexchange.com/a/183657/67781 probably gives the best advice on how to test if a key is properly passphrase-less. Something to try in a new PR.