Return concrete *os.FS from Sub() and Subvolume() #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thanks for sharing this great project!
While switching between
mem.FS
andos.FS
for different use cases, I noticed that the value returned by(*os.FS).Sub()
could not be passed verbatim to receivers that accept an interface such ashpfs.RemoveFS
. This is because bothSub()
andSubvolume()
return a generichpfs.FS
interface instead of the concrete*os.FS
type.It is a common practice in Go to "accept interfaces, return concrete types" and, since there is no ambiguity here, I believe that returning the concrete
*os.FS
is the right thing to do. It avoids awkward assertions such as: