Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky hols #999

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Sticky hols #999

merged 3 commits into from
Dec 20, 2024

Conversation

malted
Copy link
Member

@malted malted commented Dec 20, 2024 •
edited
Loading

image

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:03pm

NeonGamerBot-QK
NeonGamerBot-QK approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@NeonGamerBot-QK NeonGamerBot-QK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@maxwofford
Copy link
Member

This should have a link to the explanation post or some short description of how this advent calendar works!

ajhalili2006
ajhalili2006 reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@ajhalili2006 ajhalili2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be tempted to do a LGTM even though OAuth is broken on preview environments right now (redirect_uri related issues), so I leave a comment for now.

@malted
Copy link
Member Author

malted commented Dec 20, 2024

image

@malted
Copy link
Member Author

malted commented Dec 20, 2024 •
edited
Loading

Might be tempted to do a LGTM even though OAuth is broken on preview environments right now (redirect_uri related issues), so I leave a comment for now.

@ajhalili2006 OAuth has never worked for previews because it would require us to add every single one to slack manually :/
The way we test these is to check it out and run it locally - oauth works for localhost! :)

@malted malted merged commit f9319dc into main Dec 20, 2024
3 checks passed
@malted malted deleted the malted/sticky-holidays branch December 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajhalili2006 ajhalili2006 ajhalili2006 left review comments

@taciturnaxolotl taciturnaxolotl taciturnaxolotl approved these changes

@NeonGamerBot-QK NeonGamerBot-QK NeonGamerBot-QK approved these changes

@maxwofford maxwofford Awaiting requested review from maxwofford maxwofford is a code owner

@polytroper polytroper Awaiting requested review from polytroper polytroper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@malted @maxwofford @ajhalili2006 @NeonGamerBot-QK @taciturnaxolotl