Make orb selection instant per OMSI request #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Resolves #1121 |
DingoEatingFuzz
approved these changes
Oct 28, 2019
| const { isActive } = this.state; | ||
| if (isActive) { | ||
| this.setState({ isComplete: true }); | ||
| } |
There was a problem hiding this comment.
It looks like this changes the way the game works a bit. Now the item is captured immediately instead of after a second?
Probably unimportant, but figured I'd bring it up.
There was a problem hiding this comment.
It's captured the moment it's pressed rather than after a second. Code's a little weird, but it works.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now click / tap / touch to select orb rather than needing to hold the orb. Gauge still shows and orb still flies! Ran through the whole game and worked like a dream