Guides 2.1: Add documentation for FormHelper #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodosha
requested changes
Nov 6, 2023
content/v2.1/helpers/form_helper.md
Outdated
| **Basic Example** | ||
|
|
||
| ```ruby | ||
| <%= form_for("book", "/books", class: "form-horizontal") do |f| %> |
There was a problem hiding this comment.
@swilgosz It's time to use routing helpers 😉 .
content/v2.1/helpers/form_helper.md
Outdated
|
|
||
| As you can see, all the fields had been prefixed with the form's name, which is a string `book`, passed as a first argument. | ||
|
|
||
| To show CSRF meta tags, you need to have [sessions enabled](/v2.0/actions/sessions). Without that, you won't have the `csrf_token` hidden input field available. |
There was a problem hiding this comment.
Suggested change
| To show CSRF meta tags, you need to have [sessions enabled](/v2.0/actions/sessions). Without that, you won't have the `csrf_token` hidden input field available. |
@swilgosz This is out of context.
You wrote a section that explains CSRF protection, maybe let's move it there.
There was a problem hiding this comment.
I disagree. Because we have sessions disabled by default, but our examples assume it's enabled, I think it makes sense to mention the chapter when it's explained how to enable sessions. I've just removed the CSRF explanation, but kept the link
Co-authored-by: Luca Guidi <[email protected]>
Co-authored-by: Luca Guidi <[email protected]>
Co-authored-by: Luca Guidi <[email protected]>
Co-authored-by: Luca Guidi <[email protected]>
Co-authored-by: Luca Guidi <[email protected]>
swilgosz
force-pushed
the
docs/guides-2.1-form-helpers
branch
from
ba08159 to
0eed627
Compare
|
@jodosha ready for another round of review, but |
We do not have a syntax highlighting for ERB snippets.
|
Merging as the code had been approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #201