New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for view id setting #4821

Open

Frozen wants to merge 1 commit into dev from fix/not-ready-set-viewid

Contributor

Frozen commented Dec 21, 2024 •

edited

Loading

I faced with log message like this one
"shardID":0,"myBlock":3,"myViewID":2,

the only one way how it's possible is https://github.com/harmony-one/harmony/blob/dev/consensus/consensus_v2.go#L399 where we set block number, but not view id. I checked logs, and it shows that method syncNotReadyChan was called.


          Fix set view ids.

ca24926

Frozen self-assigned this

Frozen marked this pull request as draft

December 21, 2024 04:07

Frozen marked this pull request as ready for review

December 23, 2024 18:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet