Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable-vmi-controller option and fix 4459 #35

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

chrisho
Copy link
Contributor

@chrisho chrisho commented Sep 7, 2023

Problem:
harvester/harvester#4459
harvester/harvester#4432

Solution:

  • Add a disable-vmi-controller option to stop the node topology sync.
    • Use the cloud provider package's parameter additionalFlags to add the --disable-vmi-controller option.
    • The defect is after performing cloud-provider --help, it doesn't show the --disable-vmi-controller option.
  • Fix the logic for getting node.
    • Get the guest node through the VMI name.
    • Return nil if not found, no more errors returns.

Related Issue:
harvester/harvester#4459
harvester/harvester#4432

Test plan:

  1. Set topology.kubernetes.io/zone label for each harvester node. The value must be different.
  2. Provide two guest clusters of rke2 in the same namespaces.
  3. Check the cloud provider container log of the guest cluster. There are "not found" errors.
  4. Edit the cloud provider deployment configuration and add the option --disable-vmi-controller=true to the arguments.
  5. Check the cloud provider container log of the guest cluster. There is no "not found" error.

@chrisho chrisho requested a review from guangbochen September 7, 2023 10:34
@chrisho chrisho marked this pull request as ready for review September 12, 2023 07:22
@bk201 bk201 requested review from FrankYang0529 and removed request for starbops September 20, 2023 08:46
Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@FrankYang0529 FrankYang0529 removed their request for review March 25, 2024 02:31
@bk201 bk201 requested a review from starbops April 10, 2024 07:10
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@FrankYang0529 FrankYang0529 merged commit f06da87 into harvester:master Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants