Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use vm name to get vmi #39

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

FrankYang0529
Copy link
Member

@FrankYang0529 FrankYang0529 commented Mar 8, 2024

harvester/harvester#4947

Test steps

  1. Follow https://docs.harvesterhci.io/v1.2/rancher/cloud-provider#deploying-to-the-k3s-cluster-with-harvester-node-driver-experimental to create a RKE2 cluster.
    1-1. For Helm chart, use version v0.2.4.
    1-2. Set hostname in the cloud-config.
  2. After cluster is up, it can't finish. Use the image from current branch to replace kube-system/harvester-cloud-provider. You may need to delete old harvester-cloud-provider pod manually, because it has anti-affinity.
  3. The cluster should be up.

@FrankYang0529 FrankYang0529 requested a review from starbops March 8, 2024 04:16
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@FrankYang0529 FrankYang0529 merged commit 86465fd into harvester:master Mar 8, 2024
4 checks passed
@FrankYang0529 FrankYang0529 deleted the HARV-4947 branch March 8, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants