Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to github action #42

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

w13915984028
Copy link
Member

@w13915984028 w13915984028 changed the title More CI to github action Move CI to github action Jun 3, 2024
@w13915984028
Copy link
Member Author

@Vicente-Cheng I copied the changes from your csi driver PR, please help reviewing, thanks.

@Vicente-Cheng
Copy link

Hi @w13915984028
The GHA path should be located .github/workflows/xxx instead github/workflows/xxx.

Please help to update again. Thanks!

@w13915984028 w13915984028 force-pushed the actionmigrate branch 3 times, most recently from e8b8751 to d330eab Compare June 3, 2024 11:20
Copy link

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

juat a nit, others LGTM. Thanks!

scripts/build Outdated Show resolved Hide resolved
@bk201
Copy link
Member

bk201 commented Jun 3, 2024

@w13915984028 We also need to create an EIO ticket to migrate secrets, for example: https://github.com/rancherlabs/eio/issues/2343

@w13915984028
Copy link
Member Author

@bk201 The EIO ticket is on the way. thanks.

Signed-off-by: Jian Wang <[email protected]>
@bk201 bk201 merged commit 5e276ec into harvester:master Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants