Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed error when lb fail to get IP #44

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

w13915984028
Copy link
Member

@w13915984028 w13915984028 commented Jul 10, 2024

issue: harvester/harvester#6123

After harvester/load-balancer-harvester#31 is merged, the LB will add specific message to Ready condition to indicate vairous of error cases.

Cloud-provider can have this in advance.

Wrangler GetMessage does no harm if no codition is available.

func (c Cond) GetMessage(obj interface{}) string {
	cond := findOrNotCreateCond(obj, string(c))
	if cond == nil {
		return ""
	}
	return getFieldValue(*cond, "Message").String()
}

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@starbops starbops merged commit 73c0e1f into harvester:master Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants