Add -strict to error if there is a key missing #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
approved these changes
Nov 12, 2019
|
@jrasell I think maybe you are going to have to be the one to smash the merge button on this. |
|
@jrasell Waiting for this one to be merged as well :) |
|
|
|
Hi, is there anything blocking the merge of this PR? Looks like tests pass and it's been approved by the maintainer. |
|
Getting this in would be great. Any update? |
|
Could we get this merged please we have been bitten by failed deployments a few times due to missing key values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you forget to pass in variable you'll be left with
<no value>in the template.This prevents rendering of templates unless all of the variables are set.
Not sure of the name
-strict😆📝 perhaps this should be the default behaviour