Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Update max_unavailable and max_surge validate functions #2653

Merged
merged 2 commits into from
Dec 18, 2024
Merged

🐛 Update max_unavailable and max_surge validate functions #2653

merged 2 commits into from
Dec 18, 2024

Conversation

arybolovlev
Copy link
Contributor

Description

Update validation function for the kubernetes_daemon_set_v1 resource for the following fields: spec.strategy.rolling_update.max_surge and spec.strategy.rolling_update.max_unavailable.

References

N/A.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@arybolovlev arybolovlev marked this pull request as ready for review December 18, 2024 08:37
@arybolovlev arybolovlev requested a review from a team as a code owner December 18, 2024 08:37
@arybolovlev arybolovlev merged commit 7bba357 into main Dec 18, 2024
21 of 25 checks passed
@arybolovlev arybolovlev deleted the update-regex-max-surge branch December 18, 2024 12:10
JaylonmcShan03 pushed a commit that referenced this pull request Jan 9, 2025
@arybolovlev @JaylonmcShan03
Update max_unavailable and max_surge validate functions (#2653)
ec6ed77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arybolovlev @alexsomesan