Code

Support structured diagnostics 2#4433

Code

Merged

fendor merged 76 commits intohaskell:masterhaskell/haskell-language-server:masterfrom noughtmare:support-structured-diagnosticsnoughtmare/haskell-language-server:support-structured-diagnosticsCopy head branch name to clipboardJan 4, 2025

+982-358

Commits

Commits on Oct 23, 2024

• Change FileDiagnostic type synonym to a datatype

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  bd1404f

• Make ideErrorWithSource produce FileDiagnostic by adding filepath arg

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  e684905

• Supply structured error wherever we easily can - TODOs for hard parts

  Show description for 9d4cad1
  

  dylan-thinnes

  authored and

  noughtmare

  committed
  9d4cad1

• Fix UnitTests for new FileDiagnostic struct

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  e6a0b09

• Remove explicit uses of FileDiagnostic, add codes to LSP diagnostics

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  d87c246

• Add field for expected error codes in ghcide tests

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  cc2188c

• Expect GHC-83865 for "type error" test - basic test

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  d2cbe55

• Return structured warnings in TcModuleResult by copying from Driver

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  6e1eab7

• Store FileDiagnostic instead of LSP Diagnostic in Shake store

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  dcf9397

• Add expected error codes for diagnostics that have them

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  7bda67b

• Dispatch TODOs, amend remaining TODOs as future work

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  6d1f0d7

• Add scary comments all over copied code in Compat.Driver

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  c92afae

• Update all remaining diagnostics that could use an expected error code

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  b2fb63d

• Add _code to pretty printing for FileDiagnostic

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  c6bc82d

• Use case instead of maybe for StructuredMessage match

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  9f5391b

• Use CPP to prevent setting _code before structured errors

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  dd2229a

• Swap modifier for lenses, document StructuredMessage type

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  094974d

• Add link to Issue & MR to Compat.Driver

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  e948f2a

• Drop attachReason logic from withWarnings, technically incorrect

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  79fd77e

• Revert "Drop attachReason logic", needed by pragmas-plugin

  Show description for 869edd6
  

  dylan-thinnes

  authored and

  noughtmare

  committed
  869edd6

• Fix plugins where necessary for new diagnostic structure

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  1b2dd28

• Fix build issues with other tests from expectDiagnostics

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  03c8409

• Improve comment on metadata fdStructuredMessage in FileDiagnostic

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  2f83b0b

• Add note to withWarnings explaining the current state of things

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  1cb1325

• Attach reasons into data field of LSP Diagnostic instead of code field

  Show description for 9337f25
  

  dylan-thinnes

  authored and

  noughtmare

  committed
  9337f25

• Fix up mistakes from merge, TODO fix merge issues for 9.3.0

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  a857b9e

• Set CodeDescription from HaskellErrorIndex when available

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  14d6697

• Remove debugging print, fix expectation for preprocessor tests

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  acbf1cb

• Fix CPP for using Show instance on DiagnosticCode

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  413d1b8

• Remove diagFromErrMsgs for GHC version < 9.6.1 using CPP

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  926b6c4

• CPP fix

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  342b9fb

• More stylish-haskell, more CPP fix

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  aaf5736

• Fix all stylish-haskell errors triggering

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  7215d80

• Fix more CPP

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  1a7856b

• Only override the LSP diagnostic code when not already set

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  0a2174d

• Fixes for stylish-haskell

  Show description for 619098e
  

  dylan-thinnes

  authored and

  noughtmare

  committed
  619098e

• Qualify s, t for FuzzySearch

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  361dd5b

• Ignore use of unsafePerformIO in FuzzySearch

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  1ec3db3

• Properly split GHC.Types.Error import in Diagnostics for stylish-haskell

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  ef5518f

• Force type signature of annotation on FuzzySearch.dictionary

  

  dylan-thinnes

  authored and

  noughtmare

  committed
  45e77c7

• DRY up definition of closure_errs

  Show description for 6ca2a19
  

  dylan-thinnes

  authored and

  noughtmare

  committed
  6ca2a19

• Remove unused imports

  noughtmare

  committed
  165e6b0

• Post-rebase fixes

  noughtmare

  committed
  1047d55

• stylish-haskell formatting

  noughtmare

  committed
  a64120f

• Fix issue with GHC 9.4

  noughtmare

  committed
  1fed0f9

• Please stylish-haskell

  noughtmare

  committed
  73bba51

• Ignore error codes when testing GHC 9.4

  noughtmare

  committed
  6c9860c

• Workaround darwin GHC bug in hls-hlint-plugin

  noughtmare

  committed
  c44a43d

• Put the workaround in the right place

  noughtmare

  committed
  1f835da

Commits on Oct 24, 2024

• Revert "Set CodeDescription from HaskellErrorIndex when available"

  Show description for 1bc221c
  noughtmare

  committed
  1bc221c

• Resolve fendor's feedback

  noughtmare

  committed
  16551d1

• Apply stylish-haskell formatting

  noughtmare

  committed
  5a6216b

• Apply more stylish-haskell formatting

  noughtmare

  committed
  4465f49

Commits on Oct 25, 2024

• Merge branch 'master' into support-structured-diagnostics

  soulomoon

  authored
  79341ed

• Resolve some of soulomoon's feedback

  noughtmare

  committed
  82367ec

• Fix small issues

  noughtmare

  committed
  ada484e

Commits on Oct 26, 2024

• Remove unused imports

  noughtmare

  committed
  6c05e23

Commits on Oct 28, 2024

• Remove StructuredDiagnostic

  noughtmare

  committed
  0776c65

Commits on Nov 21, 2024

• Revert "Remove StructuredDiagnostic"

  Show description for 65300ef
  fendor

  committed
  65300ef

• Remove the unused parameter from 'ideErrorText'

  fendor

  committed
  649e2ba

• Add documentation to diagnostic helpers

  fendor

  committed
  4c9e7a3

Commits on Dec 23, 2024

• Add action to query active diagnostics for a given Range

  Show description for af34f06
  fendor

  committed
  af34f06

• Use lens for updating Diagnostic

  fendor

  committed
  92c8b4f

• Add GHC Structured Error compatibility module

  Show description for d3b7fe6
  fendor

  committed
  d3b7fe6

• Remove unused imports

  fendor

  committed
  164dfe5

• Don't suggest -Wno-deferred-out-of-scope-variables (haskell#4441)

  Show description for 31d1cee
  

  jeukshi

  authored and

  fendor

  committed
  31d1cee

• Build HLS with GHC 9.8.3 (haskell#4444)

  fendor

  committed
  49b0ce1

• ci(mergify): upgrade configuration to current format (haskell#4454)

  Show description for 1feb07d
  

  mergify[bot]

  authored and

  fendor

  committed
  1feb07d

• More tests and better docs for cabal-add (haskell#4455)

  Show description for 3ce3cfb
  

  VenInf

  and

  fendor

  committed
  3ce3cfb

• Fix compatibility with GHC 9.4 and rename function

  fendor

  committed
  54576e1

• Use GHC Note syntax and reference Note in docs

  Show description for abd1a39
  fendor

  committed
  abd1a39

• Add doc comment for 'tmrWarnings'

  fendor

  committed
  ada6ed6

• Push CPP statements to compatibility module

  fendor

  committed
  1398a0b

• Merge remote-tracking branch 'upstream/master' into support-structured-diagnostics

  fendor

  committed
  95f65d9

• Fix formatting in Development.IDE.GHC.Compat.Error

  fendor

  committed
  371896a

Commits on Dec 25, 2024

• Merge branch 'master' into support-structured-diagnostics

  fendor

  authored
  803067a