chore: build arm64 docker images #110
Conversation
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Push image to GitHub | ||
| if: github.ref == 'refs/heads/master' |
There was a problem hiding this comment.
When I first put together the container image build and push, I intended to build the image on every PR and every merge as part of CI, but only push the image on every merge to master--hence this condition. I don't see a similar condition in your code. Is it pushing to the github container registry on every run or only if we're merging to master?
There was a problem hiding this comment.
Oh I forgot to include that part of the code. Let me fix it.
There was a problem hiding this comment.
Ah there is a small problem, you see the buildx action does everything in one go, so it builds and pushes. So I can't really tell it to push only on this condition.
.github/workflows/docker-image.yml
Outdated
| with: | ||
| context: . | ||
| platforms: linux/amd64, linux/arm64 | ||
| push: true |
There was a problem hiding this comment.
Could we add a condition here?
push: github.ref == 'refs/heads/master'
or similar?
There was a problem hiding this comment.
Huh that may actually work
|
Thank you @steveiliop56 ! |
See #108