implement incomplete completion requests #12214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
A-language-server
This was
linked to
issues
Dec 8, 2024
TornaxO7
reviewed
Dec 8, 2024
| @@ -426,29 +426,32 @@ impl Client { | |||
| let server_tx = self.server_tx.clone(); | |||
| let id = self.next_request_id(); | |||
|
|
|||
| let params = serde_json::to_value(params); | |||
| // it' important this is not part of the future so that it gets | |||
There was a problem hiding this comment.
are there some words missing or typos?
|
now I remember why I put this off for so long, we need to track the savepoint of each completion provider separately which is not possible with the way prompts work currently. Will try to store that information on the handler instead ok that worked well enough |
pascalkuthe
force-pushed
the
incomplete_completion
branch
from
9a06aea to
06539ac
Compare
erasin
added a commit
to erasin/helix
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9797 #12044 #12119 #12335
Note that the RA porblem has already been fixed upstream by disabling the corresponding feature for helix and will likely be reverted but after this we have the same feature set as vscode (because it relies on a race condition in vsocde and also in helix although it's slightly more pronounced here)