Add scalyr #1066

pierreozoux · 2017-05-12T16:28:20Z

No description provided.

k8s-ci-robot · 2017-05-12T16:28:27Z

Hi @pierreozoux. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

unguiculus · 2017-05-22T18:32:42Z

stable/scalyr/values.yaml

+# Default values for scalyr.
+image:
+  repository: scalyr/scalyr-docker-agent
+  tag: latest


Use a fixed version.

unguiculus · 2017-05-22T18:34:42Z

stable/scalyr/templates/daemonset.yaml

+metadata:
+  name: {{ template "fullname" . }}
+  labels:
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"


Add missing labels. See https://github.com/kubernetes/helm/blob/master/docs/chart_best_practices/labels.md.

pierreozoux · 2017-05-23T11:15:30Z

Thanks @unguiculus I addressed your comments.

unguiculus

Thanks for the quick changes. I've found a few more things.

unguiculus · 2017-05-23T15:45:15Z

stable/scalyr/templates/cm-agent.yaml

+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: {{ template "configuration.fullname" . }}


Is there a reason why you name the config map differently? I'd suggest to use {{ template "fullname" . }} as well.

unguiculus · 2017-05-23T15:47:07Z

stable/scalyr/templates/secrets.yaml

+    heritage: "{{ .Release.Service }}"
+type: Opaque
+data:
+  api-key: {{ default "MISSING" .Values.scalyr.apiKey | b64enc | quote }}


I don't know what makes more sense to you, but are you aware of the new required function? See https://github.com/kubernetes/helm/blob/master/docs/charts_tips_and_tricks.md#know-your-template-functions.

unguiculus · 2017-05-23T15:48:20Z

stable/scalyr/values.yaml

+  ##
+  # apiKey:
+
+resources:


Make resources configurable but do not specify defaults. This should be a conscious choice of the user.

unguiculus · 2017-05-23T15:51:38Z

stable/scalyr/templates/daemonset.yaml

+metadata:
+  name: {{ template "fullname" . }}
+  labels:
+    app: {{ template "fullname" . }}


{{ template "name" . }} would be a better choice for the app label. I'd suggest you change it everywhere.

unguiculus · 2017-05-23T16:02:29Z

I just tried to deploy the chart and got the following error:

$ helm install --name foo stable/scalyr
Error: render error in "scalyr/templates/NOTES.txt": template: scalyr/templates/NOTES.txt:1:14: executing "scalyr/templates/NOTES.txt" at <.Values.scalyr.apiKe...>: can't evaluate field apiKey in type interface {}

The same happens with helm template stable/scalyr.

prydonius · 2017-06-01T14:16:31Z

@pierreozoux ping, can you update to address @unguiculus's comments?

pierreozoux · 2017-06-02T11:24:49Z

@prydonius can we keep it on hold, I'm currently working for a client, and I want them to sign the CLA before continuing this task.

pierreozoux · 2017-06-21T17:28:31Z

Addressed the comments thanks.
(And my current employer signed the CLA)

unguiculus

Just found one more thing.

unguiculus · 2017-06-24T15:44:24Z

stable/scalyr/templates/daemonset.yaml

+  template:
+    metadata:
+      labels:
+        app: {{ template "fullname" . }}


Add release label: release: "{{ .Release.Name }}"

unguiculus · 2017-07-20T19:32:08Z

@k8s-bot ok to test

k8s-ci-robot · 2017-07-20T19:34:11Z

@pierreozoux: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-charts-e2e	`0a9e98a`	link	`/test pull-charts-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

unguiculus · 2017-08-13T13:50:57Z

Sorry for the delay. It should be possible to run install the chart with defaults.

unguiculus · 2017-09-28T19:11:16Z

Closing as stale. Feel free to reopen if/when you decide to work on this again.

- Borrwed from helm/charts#1066 - Up to date with https://www.scalyr.com/help/install-agent-kubernetes - Still needs ConfigMap support Signed-off-by: Scott Rigby <[email protected]>

scottrigby · 2019-05-07T16:05:16Z

@pierreozoux I drew from some of your earlier work for a new Scalyr Helm chart. Check out scalyr/scalyr-agent-2#118 (comment) if you're still interested in this - always up for collaboration 😄

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2017

pierreozoux force-pushed the scalyr branch from d25231c to ce555b6 Compare May 19, 2017 17:57

pierreozoux mentioned this pull request May 19, 2017

Option to not log docker metrics scalyr/scalyr-agent-2#49

Closed

unguiculus suggested changes May 22, 2017

View reviewed changes

unguiculus added the changes needed label May 22, 2017

pierreozoux force-pushed the scalyr branch from ce555b6 to ac4eac5 Compare May 23, 2017 11:14

unguiculus suggested changes May 23, 2017

View reviewed changes

prydonius added the stale label Jun 1, 2017

unguiculus changed the title ~~Add scalyr~~ [on hold] Add scalyr Jun 13, 2017

pierreozoux force-pushed the scalyr branch from ac4eac5 to a253e40 Compare June 21, 2017 17:27

prydonius changed the title ~~[on hold] Add scalyr~~ Add scalyr Jun 21, 2017

prydonius removed the stale label Jun 21, 2017

pierreozoux force-pushed the scalyr branch from a253e40 to 681db3c Compare June 21, 2017 18:02

unguiculus suggested changes Jun 24, 2017

View reviewed changes

pierreozoux force-pushed the scalyr branch from 681db3c to bfdfa22 Compare June 30, 2017 15:37

Add scalyr

0a9e98a

pierreozoux force-pushed the scalyr branch from bfdfa22 to 0a9e98a Compare June 30, 2017 15:48

pierreozoux mentioned this pull request Jul 19, 2017

Kubernetes Monitoring scalyr/scalyr-agent-2#42

Open

unguiculus approved these changes Jul 20, 2017

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2017

unguiculus added the stale label Sep 17, 2017

unguiculus closed this Sep 28, 2017

scottrigby mentioned this pull request May 7, 2019

Kubernetes manifest includes RBAC resources scalyr/scalyr-agent-2#118

Open

aksakalli mentioned this pull request Feb 14, 2020

DaemonSet is not updated for the new version scalyr/scalyr-agent-2#410

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add scalyr #1066

Add scalyr #1066

pierreozoux commented May 12, 2017

k8s-ci-robot commented May 12, 2017

unguiculus May 22, 2017

unguiculus May 22, 2017

pierreozoux commented May 23, 2017

unguiculus left a comment

unguiculus May 23, 2017

unguiculus May 23, 2017

unguiculus May 23, 2017

unguiculus May 23, 2017

unguiculus commented May 23, 2017

prydonius commented Jun 1, 2017

pierreozoux commented Jun 2, 2017

pierreozoux commented Jun 21, 2017

unguiculus left a comment

unguiculus Jun 24, 2017

pierreozoux Jun 30, 2017

unguiculus commented Jul 20, 2017

k8s-ci-robot commented Jul 20, 2017

unguiculus commented Aug 13, 2017

unguiculus commented Sep 28, 2017

scottrigby commented May 7, 2019 •

edited

Loading

Add scalyr #1066

Add scalyr #1066

Conversation

pierreozoux commented May 12, 2017

k8s-ci-robot commented May 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pierreozoux commented May 23, 2017

unguiculus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unguiculus commented May 23, 2017

prydonius commented Jun 1, 2017

pierreozoux commented Jun 2, 2017

pierreozoux commented Jun 21, 2017

unguiculus left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unguiculus commented Jul 20, 2017

k8s-ci-robot commented Jul 20, 2017

unguiculus commented Aug 13, 2017

unguiculus commented Sep 28, 2017

scottrigby commented May 7, 2019 • edited Loading

scottrigby commented May 7, 2019 •

edited

Loading