Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages for review #48

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented Sep 17, 2024

Unit tests for all error messages introduced in #47

Error messages can be seen by expanding the errors.rs file in the files changed view.

@colincasey colincasey self-assigned this Sep 17, 2024
@colincasey colincasey requested a review from a team as a code owner September 17, 2024 20:52
@colincasey colincasey added the skip changelog Skip the check-changelog check label Sep 18, 2024
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
@colincasey colincasey force-pushed the error_messages_for_review branch from c5ab257 to bd62c62 Compare September 26, 2024 19:00
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
src/errors.rs Show resolved Hide resolved
@colincasey colincasey requested a review from heicheng18 October 4, 2024 18:42
@colincasey colincasey force-pushed the error_messages_for_review branch from bc5d5c2 to 233c959 Compare October 4, 2024 20:10
@colincasey colincasey merged commit dc1ba69 into error_handling Oct 7, 2024
6 checks passed
@colincasey colincasey deleted the error_messages_for_review branch October 7, 2024 15:31
@edmorley edmorley removed the request for review from a team October 10, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Skip the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants