-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error messages for review #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
heicheng18
reviewed
Sep 26, 2024
colincasey
commented
Sep 26, 2024
colincasey
commented
Sep 26, 2024
colincasey
commented
Sep 26, 2024
colincasey
commented
Sep 26, 2024
colincasey
commented
Sep 26, 2024
colincasey
commented
Sep 26, 2024
colincasey
commented
Sep 26, 2024
colincasey
force-pushed
the
error_messages_for_review
branch
from
September 26, 2024 19:00
c5ab257
to
bd62c62
Compare
heicheng18
reviewed
Oct 3, 2024
colincasey
commented
Oct 4, 2024
heicheng18
approved these changes
Oct 4, 2024
colincasey
force-pushed
the
error_handling
branch
from
October 4, 2024 20:01
c24d9ec
to
702a4a9
Compare
Stacked PR related to #47
Co-authored-by: Helen Cheng <[email protected]>
Co-authored-by: Helen Cheng <[email protected]>
colincasey
force-pushed
the
error_messages_for_review
branch
from
October 4, 2024 20:10
bc5d5c2
to
233c959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for all error messages introduced in #47
Error messages can be seen by expanding the
errors.rs
file in the files changed view.