Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-09 housekeeping #656

Merged
merged 5 commits into from
Sep 30, 2023
Merged

2023-09 housekeeping #656

merged 5 commits into from
Sep 30, 2023

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Sep 28, 2023

Drop 86df1f8 since it was fixed by heroku/cli#2467.

Update a few dependencies for Bundler and Composer, all together (and have dependabot group these in the future).

@dzuelke dzuelke requested a review from a team as a code owner September 28, 2023 11:46
@dzuelke dzuelke force-pushed the 2023-09-housekeeping branch 3 times, most recently from 29d0e83 to 6e1a3fe Compare September 30, 2023 10:57
@dzuelke
Copy link
Contributor Author

dzuelke commented Sep 30, 2023

Updated waitforit.sh to work around an issue with Focal based instances that would not allow trapping of SIGPIPE, which the script needed to operate (tests were hanging forever as a result, because some test dynos would never terminate) - GUS-W-14213860

New Focal based instances spawn bash in a way that does not allow the installation of SIGPIPE handlers.

But waitforit.sh needs SIGPIPE to detect when a test finishes. The workaround is to now manually issue a different signal when the write to a popeline fails.

This would cause certain tests to hang forever.

Put some comments in to better explain how the whole thing works.

GUS-W-14213860
@dzuelke dzuelke force-pushed the 2023-09-housekeeping branch from dbff3ee to 1c5fac5 Compare September 30, 2023 11:23
@dzuelke dzuelke merged commit 42d84d0 into main Sep 30, 2023
4 checks passed
@dzuelke dzuelke deleted the 2023-09-housekeeping branch September 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants