Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 preps: test updates and default version range limits #670

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

dzuelke
Copy link
Contributor

@dzuelke dzuelke commented Dec 7, 2023

Update some tests for forward compatibility with 8.3+

Also generally confine the default PHP version to something known; this prevents test failures in unrelated branches running against dev buckets with newer major builds (n.b. yes, we'll eventually re-structure this to allow more than one "develop" bucket).

GUS-W-14454295

Drop (and ignore) generated code, and use a single (Unit testing) suite, which also lets us drop modules for acceptance and functional tests.
Keep stuff up to date, and compatible with the latest PHP versions.
This is useful e.g. for testing branches in parallel, or when running against custom repositories that might receive unexpected updates.
@dzuelke dzuelke requested a review from a team as a code owner December 7, 2023 14:48
Copy link
Member

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for more even runtimes between the stacks
drop the fractions of seconds, it makes things easier to read - updating these is a manual process anyway to correct fluctuations
@dzuelke dzuelke merged commit c005882 into main Dec 7, 2023
4 checks passed
@dzuelke dzuelke deleted the php83-prep branch December 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants