Support for FIDO2 authentication #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still a lot of hardcoded values.
joamag
added
enhancement
Better encoding of Base64 and other stuff.
Was not working in a Python 2.7 env.
Related wit automated base64 decoding of string. Also removed extra verification of host (origin).
|
This can server as good inspiration for the final solution https://github.com/Yubico/python-fido2/blob/main/examples/server/server/server.py |
The code structure still requires some major changes to make it elegant. Some performance improvements are also needed.
|
We still need to structure the code elegantly and make it as performant as possible. |
Most of the code changes are related to moving FIDO2 code from admin part to account. The logic of authentication remains the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for FIDO2 authentication using fido2 Python library and WebAuthn.
Fixes #26