Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw commutative diagrams with Tikz #219

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Redraw commutative diagrams with Tikz #219

wants to merge 37 commits into from

Conversation

platipo
Copy link

@platipo platipo commented Oct 4, 2019

Fix #214

@platipo
Copy link
Author

platipo commented Oct 5, 2019

@BartoszMilewski can you do a little review and give you an opinion?

@BartoszMilewski
Copy link
Collaborator

I don't have a good way of viewing these changes

@platipo
Copy link
Author

platipo commented Oct 6, 2019

Maybe the book is more useful

category-theory-for-programmers.pdf

Copy link
Collaborator

@BartoszMilewski BartoszMilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In naturality: Functor F acting on object or morphisms should not use the subscript. It's F a, not F_a, and so on.

Copy link
Collaborator

@BartoszMilewski BartoszMilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spanmul doesn't look good

@BartoszMilewski
Copy link
Collaborator

I had a look at some of the proposed changes and overall I prefer the originals. Sorry!

@platipo
Copy link
Author

platipo commented Oct 6, 2019

For simplicity I've added all figures in overleaf and modified them locally.

@BartoszMilewski do you prefer all originals or just some of them?

@BartoszMilewski
Copy link
Collaborator

I can see overleaf, but it would be easier if I could see them side-by-side. Could you embed originals? Also, could you split the file--the recompilation tends to time out on large files.

@platipo
Copy link
Author

platipo commented Oct 6, 2019

Unfortunately compiling side-by-side would require a gigantic amount of work: uploading the images, creating a side-by-side macro and getting it to work, split various file in various parts...

I'm aware of the slowness caused by compilation and in the future I'm planning to split the thing in various files. For the moment I'm sticking with it because this is the fastest method.

@platipo
Copy link
Author

platipo commented Oct 6, 2019

I had a look at some of the proposed changes and overall I prefer the originals. Sorry!

Which are the ones you don't like?

@platipo
Copy link
Author

platipo commented Oct 6, 2019

In naturality: Functor F acting on object or morphisms should not use the subscript. It's F a, not F_a, and so on.

So I was writing all formulas wrong, is it $Fa$ in LaTeX?

@BartoszMilewski
Copy link
Collaborator

Unfortunately compiling side-by-side would require a gigantic amount of work: uploading the images, creating a side-by-side macro and getting it to work, split various file in various parts...
I meant in Overleaf. It's easy to upload and embed pictures. The hard part is finding them, and that's what I'm struggling with.

@BartoszMilewski
Copy link
Collaborator

In naturality: Functor F acting on object or morphisms should not use the subscript. It's F a, not F_a, and so on.

So I was writing all formulas wrong, is it $Fa$ in LaTeX?

I write it as $F a$ (with a space)

@platipo
Copy link
Author

platipo commented Oct 7, 2019

Unfortunately compiling side-by-side would require a gigantic amount of work: uploading the images, creating a side-by-side macro and getting it to work, split various file in various parts...

I meant in Overleaf. It's easy to upload and embed pictures. The hard part is finding them, and that's what I'm struggling with.

For the moment I added a comment with the image name and I've crated a local index to browse them using symbolic links.

@platipo
Copy link
Author

platipo commented Oct 7, 2019

category-theory-for-programmers-g497eda4.pdf

Page modified are:

  • 109
  • 116
  • 117
  • 119
  • 129
  • 178
  • 179
  • 223
  • 224
  • 224
  • 227
  • 228
  • 229
  • 230
  • 247
  • 248
  • 249
  • 250
  • 252
  • 322
  • 323
  • 324
  • 325
  • 326
  • 327

@platipo platipo marked this pull request as ready for review October 17, 2019 08:54
@hmemcpy hmemcpy force-pushed the master branch 2 times, most recently from 0e79320 to 4986511 Compare February 14, 2020 17:37
@drupol
Copy link
Collaborator

drupol commented Jul 26, 2020

If you rebase your branch and thanks to #251, you will have the PDFs automatically generated, maybe it would be nice to do it so we can see the result directly in the PDFs ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawing commutative diagrams with TikZ
3 participants