-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redraw commutative diagrams with Tikz #219
base: master
Are you sure you want to change the base?
Conversation
@BartoszMilewski can you do a little review and give you an opinion? |
I don't have a good way of viewing these changes |
Maybe the book is more useful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In naturality: Functor F acting on object or morphisms should not use the subscript. It's F a, not F_a, and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spanmul doesn't look good
I had a look at some of the proposed changes and overall I prefer the originals. Sorry! |
For simplicity I've added all figures in overleaf and modified them locally. @BartoszMilewski do you prefer all originals or just some of them? |
I can see overleaf, but it would be easier if I could see them side-by-side. Could you embed originals? Also, could you split the file--the recompilation tends to time out on large files. |
Unfortunately compiling side-by-side would require a gigantic amount of work: uploading the images, creating a side-by-side macro and getting it to work, split various file in various parts... I'm aware of the slowness caused by compilation and in the future I'm planning to split the thing in various files. For the moment I'm sticking with it because this is the fastest method. |
Which are the ones you don't like? |
So I was writing all formulas wrong, is it |
|
I write it as |
For the moment I added a comment with the image name and I've crated a local index to browse them using symbolic links. |
category-theory-for-programmers-g497eda4.pdf Page modified are:
|
0e79320
to
4986511
Compare
If you rebase your branch and thanks to #251, you will have the PDFs automatically generated, maybe it would be nice to do it so we can see the result directly in the PDFs ? |
Fix #214